Skip to content

[VectorStores] issue a warning if np.nan or np.inf are in _cosine_similarity argument Matrices #31532

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 5 commits into
base: master
Choose a base branch
from

Conversation

CasiCode
Copy link

@CasiCode CasiCode commented Jun 8, 2025

Copy link

vercel bot commented Jun 8, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Skipped Deployment
Name Status Preview Comments Updated (UTC)
langchain ⬜️ Ignored (Inspect) Visit Preview Jun 8, 2025 5:05pm

@dosubot dosubot bot added size:S This PR changes 10-29 lines, ignoring generated files. Ɑ: vector store Related to vector store module labels Jun 8, 2025
Copy link

codspeed-hq bot commented Jun 8, 2025

CodSpeed Walltime Performance Report

Merging #31532 will not alter performance

Comparing CasiCode:cosine-similarity-warnings (73fcc26) with master (ece9e31)

⚠️ Unknown Walltime execution environment detected

Using the Walltime instrument on standard Hosted Runners will lead to inconsistent data.

For the most accurate results, we recommend using CodSpeed Macro Runners: bare-metal machines fine-tuned for performance measurement consistency.

Summary

✅ 13 untouched benchmarks

@CasiCode CasiCode closed this Jun 8, 2025
@CasiCode CasiCode reopened this Jun 8, 2025
Copy link

codspeed-hq bot commented Jun 8, 2025

CodSpeed Instrumentation Performance Report

Merging #31532 will not alter performance

Comparing CasiCode:cosine-similarity-warnings (73fcc26) with master (ece9e31)

Summary

✅ 13 untouched benchmarks

@CasiCode CasiCode closed this Jun 8, 2025
@CasiCode CasiCode reopened this Jun 8, 2025
@CasiCode CasiCode closed this Jun 8, 2025
@CasiCode CasiCode reopened this Jun 8, 2025
@CasiCode CasiCode closed this Jun 8, 2025
@CasiCode CasiCode reopened this Jun 8, 2025
@CasiCode
Copy link
Author

@eyurtsev, I'd be very glad if you could check the request please

@CasiCode
Copy link
Author

@baskaryan, I would be greatful if you would check the request

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size:S This PR changes 10-29 lines, ignoring generated files. Ɑ: vector store Related to vector store module
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant