Skip to content

core: Use parametrized test in test_correct_get_tracer_project #31513

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

cbornet
Copy link
Collaborator

@cbornet cbornet commented Jun 6, 2025

No description provided.

Copy link

vercel bot commented Jun 6, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Skipped Deployment
Name Status Preview Comments Updated (UTC)
langchain ⬜️ Ignored (Inspect) Visit Preview Jun 10, 2025 8:53am

@dosubot dosubot bot added size:L This PR changes 100-499 lines, ignoring generated files. 🤖:nit Small modifications/deletions, fixes, deps or improvements to existing code or docs labels Jun 6, 2025
Copy link

codspeed-hq bot commented Jun 6, 2025

CodSpeed Walltime Performance Report

Merging #31513 will degrade performances by 10.84%

Comparing cbornet:use-pytest-in-test_langchain (ba49b0a) with master (e455fab)

⚠️ Unknown Walltime execution environment detected

Using the Walltime instrument on standard Hosted Runners will lead to inconsistent data.

For the most accurate results, we recommend using CodSpeed Macro Runners: bare-metal machines fine-tuned for performance measurement consistency.

Summary

❌ 3 regressions
✅ 10 untouched benchmarks

⚠️ Please fix the performance issues or acknowledge them on CodSpeed.

Benchmarks breakdown

Benchmark BASE HEAD Change
test_import_time[InMemoryVectorStore] 236.6 ms 263.3 ms -10.14%
test_import_time[PydanticOutputParser] 362.1 ms 402.4 ms -10.02%
test_import_time[tool] 466.8 ms 523.6 ms -10.84%

Copy link

codspeed-hq bot commented Jun 6, 2025

CodSpeed Instrumentation Performance Report

Merging #31513 will not alter performance

Comparing cbornet:use-pytest-in-test_langchain (ba49b0a) with master (e455fab)

Summary

✅ 13 untouched benchmarks

@cbornet cbornet force-pushed the use-pytest-in-test_langchain branch from 09d8cee to ba49b0a Compare June 10, 2025 08:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🤖:nit Small modifications/deletions, fixes, deps or improvements to existing code or docs size:L This PR changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant