-
Notifications
You must be signed in to change notification settings - Fork 33
azure_cosmos_db_no_sql.py does not support the Langchain Indexing API #90
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
@marlenezw I see you've committed to this before - can you help me get eyes on this? |
Hi @rayterrill, I think there should be a new release coming out soon. Will follow up and let you know! |
@marlenezw Looks like the version just released still has the same issue. LMK. |
@rayterrill Can you update the test cases as well. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Add test cases for this change.
@aayush3011 Added a test case for a predefined id. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks @rayterrill
@aayush3011 can we kick the tests off again and see if they're passing now? |
Fixes #89