Skip to content

azure_cosmos_db_no_sql.py does not support the Langchain Indexing API #90

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 8 commits into
base: main
Choose a base branch
from

Conversation

rayterrill
Copy link

Fixes #89

@rayterrill
Copy link
Author

@marlenezw I see you've committed to this before - can you help me get eyes on this?

@marlenezw
Copy link
Collaborator

Hi @rayterrill, I think there should be a new release coming out soon. Will follow up and let you know!

@rayterrill
Copy link
Author

@marlenezw Looks like the version just released still has the same issue. LMK.

@aayush3011
Copy link
Collaborator

@rayterrill Can you update the test cases as well.

Copy link
Collaborator

@aayush3011 aayush3011 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add test cases for this change.

@rayterrill
Copy link
Author

@aayush3011 Added a test case for a predefined id.

@rayterrill rayterrill requested a review from aayush3011 June 10, 2025 14:17
Copy link
Collaborator

@aayush3011 aayush3011 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks @rayterrill

@rayterrill
Copy link
Author

@aayush3011 can we kick the tests off again and see if they're passing now?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

AzureCosmosDBNoSqlVectorSearch is incompatible with Langchain Indexing API #61
3 participants