feat: Add oai cache to our frontend container #74
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
langchain-infra
commented
Mar 2, 2024
| @@ -219,6 +219,9 @@ frontend: | |||
| name: "frontend" | |||
| containerPort: 8080 | |||
| existingConfigMapName: "" | |||
| # Turn on LLM Proxy Cache | |||
| cache: | |||
There was a problem hiding this comment.
should this be on or off?
There was a problem hiding this comment.
Probably default on? People need to explicitly change oai url to use anyways?
There was a problem hiding this comment.
also any configuration params we should add here? I can also add some otehr ones like anthropic
agola11
approved these changes
Mar 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ad the option to enable an oai cache on your langsmith instance.