Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add runtime tag in CI job #81

Merged
merged 4 commits into from
May 13, 2024
Merged

Add runtime tag in CI job #81

merged 4 commits into from
May 13, 2024

Conversation

AsiaCao
Copy link
Member

@AsiaCao AsiaCao commented May 13, 2024 •
edited
Loading

  1. Add runtime tag in CI job
  2. Use http body instead of header for runtime_tag because the model class in baseten doesn't have access.

shankar-vision-eng
shankar-vision-eng approved these changes May 13, 2024
View reviewed changes
Copy link
Collaborator

@shankar-vision-eng shankar-vision-eng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@AsiaCao AsiaCao merged commit 736a0b8 into main May 13, 2024
7 checks passed
@AsiaCao AsiaCao deleted the add-runtime-tag-in-ci branch May 13, 2024 19:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shankar-vision-eng shankar-vision-eng shankar-vision-eng approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@AsiaCao @shankar-vision-eng @humpydonkey