Skip to content

feat(vision_agent): report visualization images via callback #62

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Apr 23, 2024
Merged

feat(vision_agent): report visualization images via callback #62

merged 4 commits into from
Apr 23, 2024

Conversation

@humpydonkey
Copy link
Collaborator

@humpydonkey humpydonkey commented Apr 23, 2024 •
edited
Loading

Report visualization images via callback.
This enables client apps to show those visualization images on a UI.

Images are sent via text in below format:

<VIZ>
<IMG>{base64 encoded image 1}</IMG>
<IMG>{base64 encoded image 2}</IMG>
<IMG>{base64 encoded image 3}</IMG>
</VIZ>

Minor tweaks:

  1. change b64 encoding back to PNG
  2. loosen some test assertion

dillonalaird
dillonalaird approved these changes Apr 23, 2024
View reviewed changes
Copy link
Member

@dillonalaird dillonalaird left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@humpydonkey humpydonkey merged commit f4b334d into main Apr 23, 2024
@humpydonkey humpydonkey deleted the report-viz branch April 23, 2024 16:55
azaj01 pushed a commit to azaj01/vision-agent that referenced this pull request Mar 1, 2025
@humpydonkey @AsiaCao
feat(vision_agent): report visualization images via callback (landing…
648c9f1 
…-ai#62)

* Send visualization images via callback

* Fix lint errors

* Fix lint errors

* Fix mypy error

---------

Co-authored-by: Yazhou Cao <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dillonalaird dillonalaird dillonalaird approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@humpydonkey @dillonalaird @AsiaCao