Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Bugs #265

Merged
merged 37 commits into from
Oct 11, 2024
Merged

Fix Bugs #265

merged 37 commits into from
Oct 11, 2024

Conversation

dillonalaird
Copy link
Member

@dillonalaird dillonalaird commented Oct 11, 2024 •
edited
Loading

This PR fixes several issues:

  • Fixes extra function calls returned in the code by the VisionAgentCoder which makes running the code extra slow (because it will run it twice, once for the tests and once for the extra function call)
  • Mitigates issue where occasionally the code will also contain the test cases, or test cases will also contain the code.
  • Fixes issue where adding in the test_multi_plan argument breaks because of file names with ( in them
  • Fixes issue where planning format is incorrect
  • Increase number of boxes needed to switch to count plots, increases size of font for count plots

@dillonalaird
separated out planner, renamed chat methods
ba4fe87
@dillonalaird
fixed circular imports
fe64f02
@dillonalaird
added type for plan context
841945b
@dillonalaird
add planner as separate call to vision agent
43b2a2c
@dillonalaird
export plan context
b0b56a6
@dillonalaird
fixed circular imports
e0075c7
@dillonalaird
fixed wrong key
4786133
@dillonalaird
better json parsing
69691ae
@dillonalaird
more test cases for json parsing
14332f6
@dillonalaird
have planner visualize results
87ac467
@dillonalaird
add more guard rails to remove double chat
b2cd1e5
@dillonalaird
revert changes with planning step for now
f317fc3
@dillonalaird
revert to original prompts
6805bfa
@dillonalaird
fix type issue
0f6b1bb
@dillonalaird
fix format issue
cf20778
@dillonalaird
skip examples for flake8
e7a9c5b
@dillonalaird
fix names and readme
8448255
@dillonalaird
fixed type error
dedae07
@dillonalaird
fix countgd integ test
969c420
@dillonalaird
synced code with new code interpreter arg
ad6edf1
@dillonalaird
separated out planner, renamed chat methods
ba63a60
@dillonalaird
add planner as separate call to vision agent
7ec4838
@dillonalaird
revert changes with planning step for now
29d934e
@dillonalaird
strip extra function calls from generated code
4d184bf
@dillonalaird
fix code rewrite issue with ()
a740a28
@dillonalaird
fix issue if plan format is incorrect
4e3cfaa
@dillonalaird
increase count threshold and size
c454756
@dillonalaird
switch to using tags to fix issue of mixing up code and tests
265b227
@dillonalaird
skip tests for flake8
8a84f4d
@dillonalaird
fix type issues
7b2e87f
yzld2002
yzld2002 approved these changes Oct 11, 2024
View reviewed changes
Copy link
Member

@yzld2002 yzld2002 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@dillonalaird dillonalaird merged commit d9445e3 into main Oct 11, 2024
8 checks passed
@dillonalaird dillonalaird deleted the fix-issues branch October 11, 2024 15:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yzld2002 yzld2002 yzld2002 approved these changes

@shankar-vision-eng shankar-vision-eng Awaiting requested review from shankar-vision-eng

@humpydonkey humpydonkey Awaiting requested review from humpydonkey

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dillonalaird @yzld2002