Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: view_media_artifact error #260

Merged
merged 1 commit into from
Oct 9, 2024

Conversation

yzld2002
Copy link
Member

@yzld2002 yzld2002 commented Oct 8, 2024

https://landing938428.monday.com/boards/1922513007/pulses/1922526546

  1. The view_media_artifact needs to load the media from observation first and then feed it to the LLM, so we need an local accessible media path (instead of the remote e2b path).
  2. It's safer to load the artifact's files into local directory.

Tests:

  1. View the result artifact:
  • Prod error
    image

  • Local run with e2b backend

image
  1. View the artifact first and then generate code
  • Prod error
image
  • Local run with e2b backend
image

Copy link
Member

@dillonalaird dillonalaird left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM thanks!

@dillonalaird dillonalaird merged commit 82c4d20 into main Oct 9, 2024
8 checks passed
@dillonalaird dillonalaird deleted the zhichao-1922526546-fix-view-media-artifact branch October 9, 2024 00:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants