Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix get_embedding in class AzureSim, passing self.emb_call instead of… #239

Merged
merged 2 commits into from
Sep 27, 2024

Conversation

hieutrtr
Copy link
Contributor

When using AzureVisionAgentCoder, I got error of TypeError: 'AzureOpenAI' object is not callable

image

Fixed it with just a simple code change.

@hieutrtr hieutrtr marked this pull request as draft September 22, 2024 02:40
@hieutrtr hieutrtr marked this pull request as ready for review September 22, 2024 02:40
@hieutrtr hieutrtr marked this pull request as draft September 22, 2024 02:41
@hieutrtr
Copy link
Contributor Author

Dear @AsiaCao @dillonalaird , as I see you guys are top contributors, could you please help to review my PR here.
Or something else I need to comply, please advise.

Thanks !

@hieutrtr hieutrtr marked this pull request as ready for review September 22, 2024 02:45
Copy link
Member

@dillonalaird dillonalaird left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Than you for contributing! The PR looks good, could you just run black to fix the formatting issue?

@hieutrtr
Copy link
Contributor Author

Than you for contributing! The PR looks good, could you just run black to fix the formatting issue?

Hi @dillonalaird , I reformatted it with black please help to review. Thanks !

Copy link
Member

@dillonalaird dillonalaird left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thank you for your contribution!

@dillonalaird dillonalaird merged commit 6fcdd12 into landing-ai:main Sep 27, 2024
7 of 8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants