Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve Orchestrator #222

Merged
merged 9 commits into from
Sep 9, 2024
Merged

Improve Orchestrator #222

merged 9 commits into from
Sep 9, 2024

Conversation

dillonalaird
Copy link
Member

@dillonalaird dillonalaird commented Sep 5, 2024

  • Improve prompts related to fine tuning usage
  • Add ability to pass test_multi_plan and customized_tool_names from VisionAgent to VisionAgentCoder

@dillonalaird dillonalaird force-pushed the improve-orchestrator branch 2 times, most recently from d255b1e to 1a5f087 Compare September 6, 2024 15:12
@dillonalaird dillonalaird changed the title [WIP] Improve Orchestrator Improve Orchestrator Sep 6, 2024
Copy link
Collaborator

@shankar-vision-eng shankar-vision-eng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm lacking context for some of the other changes. I will let @MingruiZhang review and approve

test_multi_plan (bool): If True, it will test tools for multiple plans and
pick the best one based off of the tool results. If False, it will go
with the first plan.
customized_tool_names (List[str]): A list of customized tools for agent to
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this similar to what @MingruiZhang developed in the UI. Send a custom list of tools to use from the overall set of tools ?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes this is the same thing. It was added to VisionAgentCoder and I just made sure it worked in VisionAgent.

Copy link
Member

@MingruiZhang MingruiZhang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, One comment to fix

overlay_counting_results,
]
)
TOOLS_INFO = get_tools_info(TOOLS) # type: ignore
Copy link
Member

@MingruiZhang MingruiZhang Sep 9, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

duplicate TOOLS_INFO as above, it should only expose FUNCTION_TOOLS . this line should be removed

@dillonalaird dillonalaird merged commit a7dd110 into main Sep 9, 2024
8 checks passed
@dillonalaird dillonalaird deleted the improve-orchestrator branch September 9, 2024 15:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants