Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add count tool #216

Merged
merged 13 commits into from
Sep 4, 2024
Merged

feat: add count tool #216

merged 13 commits into from
Sep 4, 2024

Conversation

shankar-vision-eng
Copy link
Collaborator

@shankar-vision-eng shankar-vision-eng commented Aug 28, 2024 •
edited
Loading

  • Adds a new counting tool
  • Adds visual prompt based counting as separate tool (May need refactoring later based on benchmark)
  • Adds visualization code similar to bbox overlay. However plotting boxes is very confusing given high number of instances in counting images. So we plot id which goes 0,1,2,... n-1
  • The id's are sorted by scores (high to low) so that they are easy to filter
  • Removed loca counting

Example visualization below (font size and color has changed since this was saved)
bird

@Dayof Dayof marked this pull request as ready for review August 30, 2024 19:22
@Dayof Dayof changed the title [WIP] Add count tool feat: add count tool Aug 30, 2024
dillonalaird
dillonalaird requested changes Sep 3, 2024
View reviewed changes
Copy link
Member

@dillonalaird dillonalaird left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some changes, once the endpoint is up I can run a few benchmark tests

vision_agent/tools/tools.py Show resolved Hide resolved
vision_agent/tools/tool_utils.py Show resolved Hide resolved
vision_agent/tools/tool_utils.py Show resolved Hide resolved
dillonalaird
dillonalaird approved these changes Sep 3, 2024
View reviewed changes
Copy link
Member

@dillonalaird dillonalaird left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@shankar-vision-eng shankar-vision-eng merged commit 103832d into main Sep 4, 2024
8 checks passed
@shankar-vision-eng shankar-vision-eng deleted the add_count_tool branch September 4, 2024 00:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Dayof Dayof Dayof left review comments

@dillonalaird dillonalaird dillonalaird approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@shankar-vision-eng @dillonalaird @Dayof