Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: customized_tool_names param to VisionAgentCoder #210

Merged
merged 9 commits into from
Aug 27, 2024

Conversation

MingruiZhang
Copy link
Member

Allow user to input customized_tool_names to VisionAgentCoder so user and limit and customize what tool to use.

The implementation is non-destructive, it only changes input of write_plans (so planner only uses provided customized_tool_names + a list of util tools (such as save_image). the rest is still up to VisionAgentCoder.

This means the tool user pick is not mandatory, VisionAgentCoder might still ignore the customized_tool_names if it doesn't think it solves the issue, even though it is the only choice it has

Test Case 1: default to all tools if customized_tool_names not provided

Screenshot 2024-08-26 at 18 04 43

Test Case 2: only use tools from customized_tool_names if provided

Screenshot 2024-08-26 at 18 05 26

Test Case 3: if provided tool name that does not exist yet, throw error

Screenshot 2024-08-26 at 18 05 10

Copy link
Member

@dillonalaird dillonalaird left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! I'd just make that one change to the default argument and then merge

vision_agent/agent/vision_agent_coder.py Outdated Show resolved Hide resolved
@MingruiZhang MingruiZhang merged commit b302e94 into main Aug 27, 2024
8 checks passed
@MingruiZhang MingruiZhang deleted the mingrui-08-26-agent-input-toolset branch August 27, 2024 06:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants