Add new tools #202
Merged
Add new tools #202
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shankar-vision-eng
requested changes
Aug 19, 2024
dillonalaird
force-pushed
the
add-new-tools
branch
from
4131742
to
0a0e3d0
Compare
dillonalaird
force-pushed
the
add-new-tools
branch
from
0a0e3d0
to
7867169
Compare
There was a problem hiding this comment.
LGTM! Just finished reviewing, I don't spot any issues. Let me test the badminton example and then approve it
P.S. Do you want to keep the tool name florence2_object_detection or change it to florence2_caption_to_phrase_grounding or florence2_text_based_object_detection. We can also do it in another PR
shankar-vision-eng
approved these changes
Aug 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.