Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix custom tool example #201

Merged
merged 2 commits into from
Aug 20, 2024
Merged

Fix custom tool example #201

merged 2 commits into from
Aug 20, 2024

Conversation

dillonalaird
Copy link
Member

No description provided.

yungyuantseng
yungyuantseng reviewed Aug 19, 2024
View reviewed changes
Copy link

@yungyuantseng yungyuantseng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the correction.
I also notice that there is no requirements.txt under examples/custom_tools.
I'm not sure that this will cause the problems or not.
Appreciate your efforts!

@dillonalaird
Copy link
Member Author

Thanks for the correction. I also notice that there is no requirements.txt under examples/custom_tools. I'm not sure that this will cause the problems or not. Appreciate your efforts!

Good catch, thanks! Just added

yungyuantseng
yungyuantseng approved these changes Aug 20, 2024
View reviewed changes
Copy link

@yungyuantseng yungyuantseng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's look good to me now!
I'll try this version, if I meet any problems, I'll report you!
Thank you so much.

shankar-vision-eng
shankar-vision-eng approved these changes Aug 20, 2024
View reviewed changes
Copy link
Collaborator

@shankar-vision-eng shankar-vision-eng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dillonalaird dillonalaird merged commit b5faa36 into main Aug 20, 2024
8 checks passed
@dillonalaird dillonalaird deleted the fix-example branch August 20, 2024 21:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yungyuantseng yungyuantseng yungyuantseng approved these changes

@shankar-vision-eng shankar-vision-eng shankar-vision-eng approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@dillonalaird @yungyuantseng @shankar-vision-eng