Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Minor fix and improvement #165

Merged
merged 1 commit into from
Jul 9, 2024
Merged

Minor fix and improvement #165

merged 1 commit into from
Jul 9, 2024

Conversation

humpydonkey
Copy link
Collaborator

Minor fix and improvement

  1. Fix the issue that str result is wrapped with single quotes by notebook.
  2. Cache top_k() for better performance

@humpydonkey
1. Fix the issue that str result is wrapped with single quotes by not…
6e5ac4b 
…ebook.

2. Cache top_k() for better performance
dillonalaird
dillonalaird approved these changes Jul 9, 2024
View reviewed changes
Copy link
Member

@dillonalaird dillonalaird left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@AsiaCao AsiaCao merged commit 7907a11 into main Jul 9, 2024
8 checks passed
@AsiaCao AsiaCao deleted the fix-single-quote branch July 9, 2024 21:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dillonalaird dillonalaird dillonalaird approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@humpydonkey @dillonalaird @AsiaCao