-
Notifications
You must be signed in to change notification settings - Fork 359
feat!: refactor Dataset#config api and expose it via pylance #4041
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
6741aff
to
15c00f8
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #4041 +/- ##
=======================================
Coverage 79.18% 79.18%
=======================================
Files 300 300
Lines 114101 114101
Branches 114101 114101
=======================================
+ Hits 90347 90350 +3
+ Misses 20272 20270 -2
+ Partials 3482 3481 -1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
cc @jackye1995 , marked the PR as ready for review |
Any update on this? |
6bc560f
to
268b98c
Compare
268b98c
to
5236468
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me, pending CI passing. Also the current description seems empty, we should describe the breaking change.
@jackye1995 The breaking change policy failed. Shall we update the version? Or just ignore? |
Yeah if you are the first author to do breaking change after the last release, then you need to do the version bump |
BREAKING CHANGE: the config API's signature from:
To