fix: flat KNN column stats order doesn't match schema #3451
+6
−3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: BubbleCal <[email protected]>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3451 +/- ##
==========================================
+ Coverage 78.81% 78.83% +0.02%
==========================================
Files 251 251
Lines 92821 92824 +3
Branches 92821 92824 +3
==========================================
+ Hits 73159 73182 +23
+ Misses 16686 16663 -23
- Partials 2976 2979 +3
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
wjones127
approved these changes
Feb 14, 2025
| .zip(schema.fields()) | ||
| .filter(|(_, field)| field.name() != DIST_COL) | ||
| .map(|(stats, _)| stats) | ||
| .chain(std::iter::once(ColumnStatistics::new_unknown())) |
There was a problem hiding this comment.
Maybe not important, but I feel like we could do better with:
- min -> 0.0
- null_count ->
vector_column.null_count
|
@BubbleCal can we add a test? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this causes an error when query with distance range, and there are unindexed rows