refactor(java): simpilfy fragment #3307
Conversation
|
BTW. current json verion is incompatible with newest spark. java.lang.NoSuchMethodError: 'java.util.Iterator org.json.JSONArray.iterator()'. this PR also solves this problem. |
eddyxu
requested review from
wjones127 and
LuQQiu
and removed request for
wjones127
|
|
||
| import java.io.Serializable; | ||
|
|
||
| public class DataFile implements Serializable { |
There was a problem hiding this comment.
Should we put these files into a sub package named fragment?
|
|
||
| import java.io.Serializable; | ||
|
|
||
| public class DeletionFile implements Serializable { |
There was a problem hiding this comment.
If the rust DeletionFile add some new filed, is this old DeletionFile also can be used?
java/core/pom.xml
Outdated
| @@ -8,7 +8,7 @@ | |||
| <parent> | |||
| <groupId>com.lancedb</groupId> | |||
| <artifactId>lance-parent</artifactId> | |||
| <version>0.21.1</version> | |||
| <version>0.21.2</version> | |||
There was a problem hiding this comment.
The java version is the same with other langue. Shoud we bump java version here?
There was a problem hiding this comment.
I reverted the change
chenkovsky
force-pushed
the
feature/refactor
branch
from
f251d4e to
01c0569
Compare
chenkovsky
force-pushed
the
feature/refactor
branch
from
a06af51 to
ce65400
Compare
in check_versions.py, we need to bump version to 0.22. I don't know is this necessary? |
chenkovsky
changed the title
|
Thanks for the contribution, @chenkovsky . Once the conflicts are fixed, we can merge it. |
Ok. I have to revert the previous merged pr. 🤣 |
In PR #3240, python code is refactored, fragment is dataclass now. This PR refactors Java code, make the API consistent with python api.