feat(java): create ivf pq index via Java #2103
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
beinan
reviewed
Mar 25, 2024
| */ | ||
| public IndexBuilder ivfPq(int numPartitions, int numSubVectors) throws IOException { | ||
| if (this.params.isPresent()) { | ||
| throw new IOException("A different index parameter already set."); |
There was a problem hiding this comment.
I think it might be better to throw a runtime exception or IllegalState exception, because it's not something from IO, what do you think?
| * @param numPartitions Number of IVF Partitions. | ||
| * @param numSubVectors Number of PQ sub-vectors. | ||
| */ | ||
| public IndexBuilder ivfPq(int numPartitions, int numSubVectors) throws IOException { |
There was a problem hiding this comment.
is buildIvfPqIndex() a better method name?
| /** Build a Scalar index. */ | ||
| public IndexBuilder scalar() throws IOException { | ||
| if (this.params.isPresent()) { | ||
| throw new IOException("A different index parameter already set."); |
There was a problem hiding this comment.
ditto, IOException might be not appropriate here
| this.replace); | ||
|
|
||
| } else { | ||
| throw new IOException("Unsupported Index Parameter"); |
| var params = this.params.get(); | ||
| if (params instanceof IvfPqParams) { | ||
| if (columns.size() != 1) { | ||
| throw new IOException("Can only create IVF_PQ on one column, got: " + columns); |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.