Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Kotlin, Gradle & SDK updates #28

Open
wants to merge 9 commits into
base: main
Choose a base branch
from
Open

Kotlin, Gradle & SDK updates #28

wants to merge 9 commits into from

Conversation

cyb3rko
Copy link
Contributor

@cyb3rko cyb3rko commented Feb 19, 2025 •
edited
Loading

Closes #26

@cyb3rko cyb3rko marked this pull request as ready for review February 22, 2025 11:47
@cyb3rko
Copy link
Contributor Author

cyb3rko commented Feb 22, 2025

@lambdapioneer I am not entirely sure about the maven publishing because I can not test it, the rest works well.

@cyb3rko
Copy link
Contributor Author

cyb3rko commented Feb 22, 2025

I did not invest more time to make the app pretty in Android 15, due to #10

lambdapioneer
lambdapioneer approved these changes Feb 23, 2025
View reviewed changes
Copy link
Owner

@lambdapioneer lambdapioneer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you very much! This looks good.

You can test most of the publishing step by creating a GPG keypair (if you do not have one yet) and them running

./gradlew publishReleasePublicationToLocalRepository --no-daemon

That should create all .aar and metadata files in a local folder. Either way, I'll test this when cutting the next release.

settings.gradle.kts
@@ -0,0 +1,18 @@
@file:Suppress("UnstableApiUsage")
Copy link
Owner

@lambdapioneer lambdapioneer Feb 23, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we add a short comment that explains which API requires us to use this Suppress statement?

@lambdapioneer lambdapioneer added the infra Build, CI/CD, and release infrastructure label Feb 23, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lambdapioneer lambdapioneer lambdapioneer approved these changes

Assignees
No one assigned
Labels
infra Build, CI/CD, and release infrastructure
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Kotlin & Gradle updates
2 participants
@cyb3rko @lambdapioneer