support BENCHMARK_CAPTURE macro #3
Open
+2
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hey there, thanks for the PR. I have been planning to add some unit tests to this code for a while now. I think it would be a good idea to not merge this PR until I add them. Once the tests are in place, I'll be happy to merge this PR |
|
Sounds good to me.
…On Thu, Sep 26, 2019, 08:39 Lakshay Garg ***@***.***> wrote:
Hey there, thanks for the PR. I have been planning to add some unit tests
to this code for a while now. I think it would be a good idea to not merge
this PR until I add them. Once the tests are in place, I'll be happy to
merge this PR
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#3?email_source=notifications&email_token=AB2ORDICXT6Y6V65DAOU3V3QLRDJFA5CNFSM4IYSIRB2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD7ULSFY#issuecomment-535345431>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AB2ORDNPZ4ATBVKRTUU22ALQLRDJFANCNFSM4IYSIRBQ>
.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Using the BENCHMARK_CAPTURE macro adds another level to the benchmark name so the results show as function/benchmark_name/input_size which interfere with the parsing.
This PR fixes this issue in a backward compatible manner.