fixed issue #2791 Improved robustness of Response process and added debugging information #2792
+12
−3
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Improvements have been made to the WriteHeader and Flush methods of response.go.
1. Check logger existence with
WriteHeader
:r.echo
andr.echo.Logger.Warn
are notnil
before callingr.echo.Logger.Warn
. This reduces the risk of panic due to unexpected nil pointer references2. Additional error logging with
Flush
:.If
http.ResponseController.Flush()
returns an error other thanhttp.ErrNotSupported
, it will now log the error if in debug mode (r.echo.Debug == true
). This additional logging is useful for debugging during development, since theFlush
method of thehttp.Flusher
interface is by convention not to return errors, but theResponseController
may.