feat(BA-2263): Abstract storage-proxy storage types
#5750
+502
−428
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
comp:storage-proxy
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| if not isinstance(storage, ObjectStorage): | ||
| raise StorageNotFoundError(f"Storage '{storage_name}' is not an ObjectStorage") | ||
|
|
||
| # TODO: Remove this after supporting multiple buckets |
Check notice
Code scanning / devskim
A "TODO" or similar was left in source code, possibly indicating incomplete functionality Note
github-actions
bot
added
size:XL
jopemachine
force-pushed
the
feat/abstract_storage_proxy_storages
branch
from
26bd8d0 to
7258ff0
Compare
jopemachine
force-pushed
the
feat/abstract_storage_proxy_storages
branch
from
7258ff0 to
7e3fef7
Compare
jopemachine
changed the title
storage-proxy storage types
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolves #5748 (BA-2263)
Checklist: (if applicable)
📚 Documentation preview 📚: https://sorna--5750.org.readthedocs.build/en/5750/
📚 Documentation preview 📚: https://sorna-ko--5750.org.readthedocs.build/ko/5750/