feat(BA-1950): Action Processor to handle various types of targets #5744
+357
−57
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
size:L
7 tasks
fregataa
changed the title
There was a problem hiding this comment.
Pull Request Overview
This PR implements an Action Processor system to handle various types of targets in the AI Backend manager. It introduces a modular architecture with specialized processors for different action types (single entity, scope, and batch operations) along with corresponding validators.
- Refactors the action processing system with type-specific processors and validators
- Adds specialized action classes for single entity, scope, and batch operations
- Moves validation logic to a dedicated validator module structure
Reviewed Changes
Copilot reviewed 16 out of 17 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| src/ai/backend/manager/actions/validators/auth_validator.py | Updates import path for ActionValidator |
| src/ai/backend/manager/actions/validator/*.py | Introduces specialized validator classes for different action types |
| src/ai/backend/manager/actions/processor/*.py | Implements type-specific action processors with common processing logic |
| src/ai/backend/manager/actions/action/*.py | Defines base action classes and specialized action types for different targets |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
Comment on lines
37
to
92
| async def _run(self, action: TSingleEntityAction) -> TSingleEntityActionResult: | ||
| started_at = datetime.now() | ||
| status = OperationStatus.UNKNOWN | ||
| description: str = "unknown" | ||
| result: Optional[TSingleEntityActionResult] = None | ||
| error_code: Optional[ErrorCode] = None | ||
|
|
||
| action_id = uuid.uuid4() | ||
| action_trigger_meta = BaseActionTriggerMeta(action_id=action_id, started_at=started_at) | ||
| for monitor in self._monitors: | ||
| try: | ||
| await monitor.prepare(action, action_trigger_meta) | ||
| except Exception as e: | ||
| log.warning("Error in monitor prepare method: {}", e) | ||
| try: | ||
| for validator in self._validators: | ||
| await validator.validate(action, action_trigger_meta) | ||
| result = await self._func(action) | ||
| except BackendAIError as e: | ||
| log.exception("Action processing error: {}", e) | ||
| status = OperationStatus.ERROR | ||
| description = str(e) | ||
| error_code = e.error_code() | ||
| raise | ||
| except BaseException as e: | ||
| log.exception("Unexpected error during action processing: {}", e) | ||
| status = OperationStatus.ERROR | ||
| description = str(e) | ||
| error_code = ErrorCode.default() | ||
| raise | ||
| else: | ||
| status = OperationStatus.SUCCESS | ||
| description = "Success" | ||
| return result | ||
| finally: | ||
| ended_at = datetime.now() | ||
| duration = ended_at - started_at | ||
| entity_id = action.entity_id() | ||
| if entity_id is None and result is not None: | ||
| entity_id = result.entity_id() | ||
| meta = BaseActionResultMeta( | ||
| action_id=action_id, | ||
| entity_id=entity_id, | ||
| status=status, | ||
| description=description, | ||
| started_at=started_at, | ||
| ended_at=ended_at, | ||
| duration=duration, | ||
| error_code=error_code, | ||
| ) | ||
| process_result = ProcessResult(meta=meta) | ||
| for monitor in reversed(self._monitors): | ||
| try: | ||
| await monitor.done(action, process_result) | ||
| except Exception as e: | ||
| log.warning("Error in monitor done method: {}", e) |
There was a problem hiding this comment.
This entire _run method is duplicated across all three processor classes (single_entity.py, scope.py, batch.py). Consider extracting this common logic into a base class or shared utility function to eliminate code duplication.
Copilot uses AI. Check for mistakes.
HyeockJinKim
reviewed
Sep 5, 2025
Comment on lines
+7
to
+10
| class BaseBatchAction(BaseAction): | ||
| @override | ||
| def entity_id(self) -> Optional[str]: | ||
| return None |
There was a problem hiding this comment.
Is the entity_id for backward compatibility?
There was a problem hiding this comment.
yes, it overrides BaseAction method
fregataa
force-pushed
the
feat/add-processors-based-on-action-types
branch
from
bfdd80a to
2cf1a22
Compare
HyeockJinKim
approved these changes
Sep 11, 2025
fregataa
force-pushed
the
feat/add-processors-based-on-action-types
branch
from
2cf1a22 to
4db5743
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolves #5313 (BA-1950)
Checklist: (if applicable)
ai.backend.testdocsdirectory