Skip to content

Conversation

seedspirit
Copy link
Contributor

resolves #5663 (BA-2213)

Checklist: (if applicable)

  • Milestone metadata specifying the target backport version
  • Mention to the original issue
  • Installer updates including:
    • Fixtures for db schema changes
    • New mandatory config options
  • Update of end-to-end CLI integration tests in ai.backend.test
  • API server-client counterparts (e.g., manager API -> client SDK)
  • Test case(s) to:
    • Demonstrate the difference of before/after
    • Demonstrate the flow of abstract/conceptual models with a concrete implementation
  • Documentation
    • Contents in the docs directory
    • docstrings in public interfaces and type annotations

@seedspirit seedspirit self-assigned this Aug 28, 2025
@Copilot Copilot AI review requested due to automatic review settings August 28, 2025 04:45
@github-actions github-actions bot added size:S 10~30 LoC comp:installer Related to Installer labels Aug 28, 2025
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR adds Apollo Rover CLI installation to the development setup script to support Supergraph generation capabilities. The change integrates Rover CLI installation into the existing Backend.AI development environment setup process.

  • Adds a new install_rover_cli() function that downloads and configures Apollo Rover CLI
  • Integrates Rover CLI installation into the configure_backendai() function
  • Sets up necessary environment variables and shell configuration for Rover CLI

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

}

install_rover_cli() {
curl -sSL https://rover.apollo.dev/nix/latest | sh
Copy link
Preview

Copilot AI Aug 28, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Downloading and executing a script directly from the internet without verification poses a security risk. Consider adding checksum verification or using a pinned version to ensure the integrity of the downloaded script.

Suggested change
curl -sSL https://rover.apollo.dev/nix/latest | sh
# Download the Rover install script and verify its checksum before executing
ROVER_INSTALL_URL="https://rover.apollo.dev/nix/latest"
ROVER_INSTALL_SCRIPT="/tmp/rover_install.sh"
EXPECTED_SHA256="REPLACE_WITH_KNOWN_GOOD_SHA256"
curl -sSL "$ROVER_INSTALL_URL" -o "$ROVER_INSTALL_SCRIPT"
ACTUAL_SHA256=$(sha256sum "$ROVER_INSTALL_SCRIPT" | awk '{print $1}')
if [ "$ACTUAL_SHA256" != "$EXPECTED_SHA256" ]; then
echo -e "${RED}ERROR: Checksum verification failed for Rover install script.${WHITE}"
echo -e "${YELLOW}Expected: $EXPECTED_SHA256${WHITE}"
echo -e "${YELLOW}Actual: $ACTUAL_SHA256${WHITE}"
rm -f "$ROVER_INSTALL_SCRIPT"
return 1
fi
sh "$ROVER_INSTALL_SCRIPT"
rm -f "$ROVER_INSTALL_SCRIPT"

Copilot uses AI. Check for mistakes.

Comment on lines +928 to +929
# Install rover cli for Supergraph generation
install_rover_cli
Copy link
Preview

Copilot AI Aug 28, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The installation process lacks error handling and user feedback. If the Rover CLI installation fails, the script will continue without indication. Consider adding error checking and using the existing show_info function to provide user feedback about the installation progress.

Copilot uses AI. Check for mistakes.

@seedspirit seedspirit changed the title feat(BA-2212): Add rover cli installation in install-dev script chore(BA-2212): Add rover cli installation in install-dev script Aug 28, 2025
@github-actions github-actions bot added size:M 30~100 LoC and removed size:S 10~30 LoC labels Aug 28, 2025
@github-actions github-actions bot added size:S 10~30 LoC and removed size:M 30~100 LoC labels Aug 28, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
comp:installer Related to Installer size:S 10~30 LoC
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add rover cli installation in install-dev script
2 participants