Skip to content

feat(BA-2164): Add DB Tables for Model Deployment #5599

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

feat(BA-2164): Add DB Tables for Model Deployment #5599

wants to merge 1 commit into from
+990 −0

Conversation

seedspirit
Copy link
Contributor

@seedspirit seedspirit commented Aug 22, 2025 •
edited by github-actions bot
Loading

resolves #5585 (BA-2164)

Checklist: (if applicable)

  • Milestone metadata specifying the target backport version
  • Mention to the original issue
  • Installer updates including:
    • Fixtures for db schema changes
    • New mandatory config options
  • Update of end-to-end CLI integration tests in ai.backend.test
  • API server-client counterparts (e.g., manager API -> client SDK)
  • Test case(s) to:
    • Demonstrate the difference of before/after
    • Demonstrate the flow of abstract/conceptual models with a concrete implementation
  • Documentation
    • Contents in the docs directory
    • docstrings in public interfaces and type annotations

📚 Documentation preview 📚: https://sorna--5599.org.readthedocs.build/en/5599/

📚 Documentation preview 📚: https://sorna-ko--5599.org.readthedocs.build/ko/5599/

@seedspirit seedspirit self-assigned this Aug 22, 2025
@github-actions github-actions bot added size:XL 500~ LoC comp:manager Related to Manager component comp:common Related to Common component require:db-migration Automatically set when alembic migrations are added or updated labels Aug 22, 2025
@seedspirit seedspirit marked this pull request as ready for review August 25, 2025 01:09
@Copilot Copilot AI review requested due to automatic review settings August 25, 2025 01:09
HyeockJinKim
HyeockJinKim reviewed Aug 25, 2025
View reviewed changes
HyeockJinKim
HyeockJinKim reviewed Aug 25, 2025
View reviewed changes
HyeockJinKim
HyeockJinKim reviewed Aug 25, 2025
View reviewed changes
HyeockJinKim
HyeockJinKim reviewed Aug 25, 2025
View reviewed changes
HyeockJinKim
HyeockJinKim reviewed Aug 25, 2025
View reviewed changes
Copilot
Copilot AI reviewed Aug 25, 2025
View reviewed changes
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot encountered an error and was unable to review this pull request. You can try again by re-requesting a review.

HyeockJinKim
HyeockJinKim reviewed Aug 25, 2025
View reviewed changes
@seedspirit seedspirit force-pushed the feat/BA-2164 branch 4 times, most recently from cb3759a to 46f211f Compare August 27, 2025 09:42
@github-actions github-actions bot added the area:docs Documentations label Aug 27, 2025
seedspirit
seedspirit commented Sep 3, 2025
View reviewed changes
src/ai/backend/manager/models/deployment_route.py
GUID,
nullable=False,
)
session_id = sa.Column(
Copy link
Contributor Author

@seedspirit seedspirit Sep 3, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@HyeockJinKim how about add revision_id in deployment rout row? If the database does not hold this value, it would appear impossible to know the revision ID currently referenced by the deployment route (or replica) especially there are two revisions while deploying

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

Copilot code review Copilot Copilot left review comments

@HyeockJinKim HyeockJinKim HyeockJinKim approved these changes

Assignees

@seedspirit seedspirit

Labels
area:docs Documentations comp:common Related to Common component comp:manager Related to Manager component require:db-migration Automatically set when alembic migrations are added or updated size:XL 500~ LoC
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Define and Implement DB Tables related to Model Deployment
2 participants
@seedspirit @HyeockJinKim