feat(BA-817): Better error log during server context initialization #3796
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
comp:manager
Co-authored-by: octodog <[email protected]>
Comment on lines
+451
to
+455
| try: | ||
| await root_ctx.event_producer.ping() | ||
| except (Exception, asyncio.CancelledError) as e: | ||
| log.error("Failed to initiate event producer (error: {0})", repr(e)) | ||
| raise |
There was a problem hiding this comment.
Umm… Rather than inserting log.error in every place where an Exception might occur, it seems better to convey exceptions meaningfully and handle them in a common place.
There was a problem hiding this comment.
Which place should the error handler be? I want the logger logs the exception raised in bootstrap steps
HyeockJinKim
reviewed
Mar 1, 2025
There was a problem hiding this comment.
The direction of subsequent work should be towards applying it to the common structure, but this PR will apply it as a temporary measure for now.
Is it still in the draft state and not yet completed? @fregataa
…ging' into feat/better-server-init-fail-logging
HyeockJinKim
requested changes
Mar 20, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolves #3788 (BA-817)
Checklist: (if applicable)