refactor(BA-502): Add the skeleton interface of vfolder CRUD handlers in storage-proxy (#3434) #3516
+631
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
comp:storage-proxy
HyeockJinKim
requested changes
Jan 22, 2025
|
Please check the reason for the CI failure as well. |
I made some changes before committing, but I found that I only ran |
HyeockJinKim
reviewed
Feb 4, 2025
fregataa
reviewed
Feb 7, 2025
| class BaseModel(PydanticBaseModel): | ||
| """Base model for all models in this module""" | ||
|
|
||
| model_config = {"arbitrary_types_allowed": True} |
There was a problem hiding this comment.
Suggested change
| model_config = {"arbitrary_types_allowed": True} | |
| model_config = ConfigDict(arbitrary_types_allowed = True) |
- How about using
pydantic.ConfigDict? - Why is the config needed for all models in this module?
- Let's rename this class to
_BaseModelto represent that it is private if it is used only in thistypesmodule
|
|
||
| # Common fields for VolumeID and VFolderID | ||
| VOLUME_ID_FIELD = Field( | ||
| ..., |
There was a problem hiding this comment.
Why are those ellipsis used in pydantic field definition?
Comment on lines
+80
to
+98
| # For `get_vfolder_info`: mount | ||
| subpath: Optional[PurePosixPath] = Field( | ||
| default=None, | ||
| description="For `get_vfolder_info`\n\ | ||
| The subpath inside the virtual folder to be queried.", | ||
| ) | ||
| # For `clone_vfolder` | ||
| # You can use volume_id and vfolder_id as src_volume and src_vfolder_id. | ||
| dst_vfolder_id: Optional[VFolderID] = Field( | ||
| default=None, | ||
| validation_alias=AliasChoices( | ||
| "dst_vfid", | ||
| "dstvfolderid", | ||
| "dst_vfolder_id", | ||
| "dstVfolderId", | ||
| ), | ||
| description="For `clone_vfolder`\n\ | ||
| The destination virtual folder ID to clone to.", | ||
| ) |
There was a problem hiding this comment.
I guess the models in this module are used to serialize and validate input of API handlers.
This VFolderIDModel seems to be used in too many cases.
Let's divide this into separate models.
HyeockJinKim
reviewed
Feb 7, 2025
| @@ -0,0 +1,3 @@ | |||
| python_test_utils() | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolves #3434 (BA-502)
Add skeletion interface of storage-proxy handlers for refactoring.
Files were added in ./src/ai/backend/storage/api/vfolder
[25-01-31] Updated with applying the feedback
manager_handler.py (updated)
manager_service.py(deleted)types.py (updated)
response_model.py (added)
conftest.py(deleted)test_handler.py (updated)
Checklist: (if applicable)
ai.backend.testdocsdirectory