-
Notifications
You must be signed in to change notification settings - Fork 159
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(BA-572): Add pydantic-only API hander decorator #3511
Open
seedspirit
wants to merge
18
commits into
main
Choose a base branch
from
feat/add-pydantic-handling-decorator-for-req-res
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+958
−41
Open
Changes from all commits
Commits
Show all changes
18 commits
Select commit
Hold shift + click to select a range
140f5d1
feat: add new decorator for pydantic req/res in manager
seedspirit 649cc2c
chore: update api schema dump
seedspirit 7e85499
refactor: move pydantic handler into common pkg
seedspirit bc5b480
refactor: make decorator usage more simple using generic
seedspirit 329dab5
test: add test for pydantic api handler decorator
seedspirit 5e16452
Merge branch 'feat/add-pydantic-handling-decorator-for-req-res' of ht…
seedspirit 1683901
doc: add annotation about how to use pydantic_api_handler
seedspirit 8fbd2b6
refactor: change param type matching using type system
seedspirit 4a0d876
doc: add changelog about new api handler decorator
seedspirit e1740c1
refactor: change param parse value error to custom error
seedspirit c32a4db
refactor: remove default value from BaseResponse
seedspirit ea2d962
refactor: add type hints for param instance variables
seedspirit e5af16e
style: move decorator usage annotation into decorator func
seedspirit 2809dd6
style: fix annotation about status code defining method in BaseResponse
seedspirit 93cd54a
feat: enhance error messages with type information in Param Classes
seedspirit 42900c1
refactor: extend pydantic API decorator to support class-based handlers
seedspirit 576ed8d
style: replace annotation language into English
seedspirit 9519d29
refactor: improve http response abstraction
seedspirit File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1 @@ | ||
Add new Pydantic handling api decorator for Request/Response validation |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah, BackendError wasn’t in common package…
For now, I’ll apply it this way, and I’ll create a separate issue to organize exceptions and refactor later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'll keep it in mind until the next refactoring