-
Notifications
You must be signed in to change notification settings - Fork 159
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor(BA-483): Revamp ContainerRegistryNode
API
#3424
Open
jopemachine
wants to merge
26
commits into
topic/11-11-feat_implement_associatecontainerregistrywithgroup_disassociatecontainerregistrywithgroup_
Choose a base branch
from
topic/01-10-refactor_revamp_containerregistrynode_api
base: topic/11-11-feat_implement_associatecontainerregistrywithgroup_disassociatecontainerregistrywithgroup_
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Jan 10, 2025
Warning This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
This stack of pull requests is managed by Graphite. Learn more about stacking. |
4 tasks
adc707a
to
265cecf
Compare
ContainerRegistryNode
API
265cecf
to
bb4b42a
Compare
23a194c
to
978b571
Compare
4113540
to
0c45704
Compare
17c3313
to
a76fd01
Compare
cd53aa4
to
f5d681b
Compare
fregataa
reviewed
Jan 23, 2025
da74895
to
b4f6797
Compare
f5d681b
to
84328f7
Compare
aa71db8
to
0d8f6f5
Compare
yomybaby
requested changes
Feb 7, 2025
…stryResponseModel`
…r `common` package
…er_registry_scope()`
This reverts commit 7cebbff.
This reverts commit c09ca3f.
Co-authored-by: octodog <[email protected]>
f4553fc
to
bbc9294
Compare
c5c7f94
to
2935905
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
area:docs
Documentations
comp:client
Related to Client component
comp:common
Related to Common component
comp:manager
Related to Manager component
size:XL
500~ LoC
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #3418 (BA-483).
Outlines
Caution
This PR include breaking change.
This PR performs the following tasks:
In PR feat: Migrate container registry config storage from
Etcd
toPostgreSQL
#1917, there was some confusion as theContainerRegistryNode
API was changed to no longer usegraphene.InputObjectType
. Let's revert to usinggraphene.InputObjectType
for accepting arguments.PR feat(BA-463): Implement APIs for associating, disassociating
container_registries
withgroups
#3067 implements an API to establish the relationship betweencontainer_registries
andgroups
. It removes the undocumented APIs and adds new ones.GQL example
Refer to the
schema.graphql
file to see how the input types for each GQL query and mutation have changed.In this section, I will explain each GQL usage with examples.
create_container_registry_node
modify_container_registry_node
delete_container_registry_node
allowed_groups
Checklist: (if applicable)
docs
directory📚 Documentation preview 📚: https://sorna--3424.org.readthedocs.build/en/3424/
📚 Documentation preview 📚: https://sorna-ko--3424.org.readthedocs.build/ko/3424/