feat: add new resource policy page (keypair, user, project) #2357
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This stack of pull requests is managed by Graphite. Learn more about stacking. Join @agatha197 and the rest of your teammates on |
6 tasks
agatha197
force-pushed
the
feature/new-resource-policy-page
branch
2 times, most recently
from
bc4fb91
to
b0e755b
Compare
Coverage report for
|
St.❔ |
Category | Percentage | Covered / Total |
|---|---|---|---|
| 🔴 | Statements | 2.85% (-0.09% 🔻) |
132/4628 |
| 🔴 | Branches | 3.27% (-0.12% 🔻) |
103/3147 |
| 🔴 | Functions | 1.51% (-0.06% 🔻) |
23/1523 |
| 🔴 | Lines | 2.77% (-0.09% 🔻) |
126/4543 |
Show new covered files 🐣
St.❔ |
File | Statements | Branches | Functions | Lines |
|---|---|---|---|---|---|
| 🔴 | ... / ResourcePolicyPage.tsx |
0% | 0% | 0% | 0% |
| 🔴 | ... / KeypairResourcePolicySettingModal.tsx |
0% | 0% | 0% | 0% |
| 🔴 | ... / ProjectResourcePolicyList.tsx |
0% | 100% | 0% | 0% |
| 🔴 | ... / FormItemWithUnlimited.tsx |
0% | 0% | 0% | 0% |
| 🔴 | ... / KeypairResourcePolicyList.tsx |
0% | 0% | 0% | 0% |
| 🔴 | ... / AllowedHostNamesSelect.tsx |
0% | 100% | 0% | 0% |
| 🔴 | ... / UserResourcePolicyList.tsx |
0% | 100% | 0% | 0% |
Test suite run success
43 tests passing in 5 suites.
Report generated by 🧪jest coverage report action from 7ea98dc
yomybaby
requested changes
May 20, 2024
react/src/components/DynamicUnitInputNumberWithUnlimitedFormItems.tsx
Outdated
Show resolved
Hide resolved
agatha197
force-pushed
the
feature/new-resource-policy-page
branch
2 times, most recently
from
a32d385
to
50ad115
Compare
6 tasks
yomybaby
force-pushed
the
feature/new-resource-policy-page
branch
from
50ad115
to
1323df5
Compare
github-actions
bot
added
effort:normal
agatha197
force-pushed
the
feature/new-resource-policy-page
branch
from
1323df5
to
50ad115
Compare
6 tasks
agatha197
force-pushed
the
feature/new-resource-policy-page
branch
from
50ad115
to
946816c
Compare
14 tasks
* feat: new resources page * cosmetic touches and bordered table * Use Segment component for status and refactor codes related to the fetch transition * table sorter by GraphQL order * refactor: sorter setting and remove architecture sorter * remove auto refresh feature --------- Co-authored-by: Jong Eun Lee <[email protected]>
agatha197
force-pushed
the
feature/new-resource-policy-page
branch
from
946816c
to
ae17f55
Compare
13 tasks
yomybaby
pushed a commit
that referenced
this pull request
May 28, 2024
follows #2357 Add User Resource Policy Page ## Description - Add User resource policy CRUD. - Add `FormItemProps` props to `FormItemWithUnlimited`. - Add simple error handler to `KeypairResourcePolicySettingModal`. - Remove unused component, `ResourcePolicyCard`. ## Checklist - [ ] List Page: name, max folder count, max session count per model session, max quota scope size, id, created at - [ ] Each item will be shown/hidden according to the server version. - [ ] In particular, it is stated in the schema that `max_vfolder_count` is supported from version 24.03.1, but this is incorrectly documented, and it follows lablup/backend.ai#1993. - [ ] `max_session_count_per_model_session` is supported from version 23.09.10 as follows lablup/backend.ai#1993 too. - [ ] Create/Modal: Create or modify user resource policy. - [ ] Version compatibility is the same as the list. - [ ] Unlimited value of `Max Folder Count` is 0. - [ ] Unlimited value of `Max Folder Size` is -1. ## Screenshots <table> <tr> <td> <td>24.03.0b1 (10.82.230.101)</td> <td>24.09.0dev1 (main)</td> <tr> <td>List</td> <td>  </td> <td>  </td> <tr> <td>Create Modal</td> <td>  </td> <td>  </td> <tr> <td>Modify Modal</td> <td>  </td> <td>  </td> </tr> <tr> <td>Table Setting</td> <td>  </td> <td>  </td> </tr> </table> **Checklist:** (if applicable) - [x] Mention to the original issue - [ ] Documentation - [x] Minium required manager version - [x] Specific setting for review (eg., KB link, endpoint or how to setup) - [x] Minimum requirements to check during review - [ ] Test case(s) to demonstrate the difference of before/after
yomybaby
pushed a commit
that referenced
this pull request
May 28, 2024
follows #2357 Add Project Resource Policy Page ### TL;DR This pull request introduces changes related to FormItemWithUnlimited and ProjectResourcePolicyList components. ### What changed? The changes include: - Addition of FormItemWithUnlimitedProps in `FormItemWithUnlimited` component - Updates to `ProjectResourcePolicyList` component with enhanced functionality and UI improvements ### Checklist - [ ] List Page: name, max folder count, max quota scope size, id, created at - [ ] Each item will be shown/hidden according to the server version. - [ ] In particular, it is stated in the schema that `max_vfolder_count` is supported from version 24.03.1, but this is incorrectly documented, and it follows lablup/backend.ai#1993. - [ ] Create/Modal: Create or modify project resource policy. - [ ] Version compatibility is the same as the list. - [ ] Unlimited value of `Max Folder Count` is 0. - [ ] Unlimited value of `Max Folder Size` is -1. ### Screenshots <table> <tr> <td></td> <td>24.03.0b1 (10.82.230.101)</td> <td>24.09.0dev1 (main)</td> </tr> <tr> <td>List</td> <td>  </td> <td>  </td> </tr> <tr> <td>Create Modal</td> <td>  </td> <td>  </td> </tr> <tr> <td>Modify Modal</td> <td>  </td> <td>  </td> </tr> <tr> <td>Table Setting</td> <td>  </td> <td>  </td> </tr> </table> --- <!-- Please precisely, concisely, and concretely describe what this PR changes, the rationale behind codes, and how it affects the users and other developers. --> **Checklist:** (if applicable) - [x] Mention to the original issue - [ ] Documentation - [x] Minium required manager version - [x] Specific setting for review (eg., KB link, endpoint or how to setup) - [x] Minimum requirements to check during review - [ ] Test case(s) to demonstrate the difference of before/after
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New resource policy page
resolves #2351
Keypair resource policy page
Description
Replace the original keypair resource policy page with the react component.
Checklist
Unlimited: form value is undefined -> uncheckUnlimited: form value is reset.{}as follows server value.Screenshots
AllowedHostNamesSelectUser resource policy page
ref #2421
Project resource policy page
ref #2423
Checklist: (if applicable)