Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: resource page - user, project, keypair #2351

Closed
1 task done
agatha197 opened this issue Apr 17, 2024 · 0 comments · Fixed by #2357
Closed
1 task done

refactor: resource page - user, project, keypair #2351

agatha197 opened this issue Apr 17, 2024 · 0 comments · Fixed by #2357
Assignees
@agatha197
Labels
effort:normal Need to understand a few modules / some extent of contextual or historical information. field:UI / UX impact:visible This change is visible to users. platform:general type:enhance Add new features urgency:3 Must be finished within a certain time frame.
Milestone
24.03

Comments

@agatha197
Copy link
Contributor

agatha197 commented Apr 17, 2024 •
edited

Let's add or replace the original resource page with react component.
It should contain user, project, keypair resource tabs and admin can manage each of them.

Tasks
Beta Give feedback
  1. feat: add new resource policy page (keypair, user, project) #2357
    area:i18n area:ux effort:normal field:UI / UX field:localization impact:visible platform:general size:XL type:enhance urgency:3
    agatha197
@agatha197 agatha197 self-assigned this Apr 17, 2024
@agatha197 agatha197 added this to the 24.03 milestone Apr 17, 2024
@agatha197 agatha197 added type:enhance Add new features effort:normal Need to understand a few modules / some extent of contextual or historical information. urgency:3 Must be finished within a certain time frame. platform:general impact:visible This change is visible to users. field:UI / UX labels Apr 17, 2024
@agatha197 agatha197 mentioned this issue May 21, 2024
Merged
17 tasks
yomybaby pushed a commit that referenced this issue May 23, 2024
@agatha197
feat: add new resource policy page (keypair, user, project) (#2357)
f2c1cf2 
# New resource policy page
resolves #2351

## Keypair resource policy page
### Description
Replace the original keypair resource policy page with the react component.
### Checklist
- [ ] list page: added idle timeout, max session lifetime
- [ ] modify/create modal
  - [ ] If the value is unlimited, checkbox is checked and input is disabled.
  - [ ] If the initial value exists -> check `Unlimited`: form value is undefined -> uncheck `Unlimited`: form value is reset.
- [ ] modify modal: host name is disabled.
- [ ] create modal: host name is enabled.
- [ ] allowed host
  - [ ] It displays only host name.
  - [ ] allowed permission list follows original value.
  - [ ] If the allowed permission is undefined, the default value is `{}` as follows server value.
- [ ] you can delete keypair resource policy by clicking the delete icon in the controls column.
   
### Screenshots
- keypair resource policy list
![image.png](https://graphite-user-uploaded-assets-prod.s3.amazonaws.com/2HueYSdFvL8pOB5mgrUQ/850ea94b-15cc-4ac2-9cd8-3b3432eadaf7.png)
- Update keypair resource policy modal 
![image.png](https://graphite-user-uploaded-assets-prod.s3.amazonaws.com/2HueYSdFvL8pOB5mgrUQ/910a2a6b-5058-4d23-8fd6-aa34a059e225.png)
- Create keypair resource policy modal
![image.png](https://graphite-user-uploaded-assets-prod.s3.amazonaws.com/2HueYSdFvL8pOB5mgrUQ/9e7b7edc-d538-4f81-b219-f5712ecb2d09.png)
- `AllowedHostNamesSelect`
![image.png](https://graphite-user-uploaded-assets-prod.s3.amazonaws.com/2HueYSdFvL8pOB5mgrUQ/e06f53a9-41a5-4d41-a608-0c2f0cfb7087.png)


## User resource policy page
## Project resource policy page

**Checklist:** (if applicable)

- [ ] Mention to the original issue
- [ ] Documentation
- [ ] Minium required manager version
- [ ] Specific setting for review (eg., KB link, endpoint or how to setup)
- [x] Minimum requirements to check during review
- [ ] Test case(s) to demonstrate the difference of before/after
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@agatha197 agatha197

Labels
effort:normal Need to understand a few modules / some extent of contextual or historical information. field:UI / UX impact:visible This change is visible to users. platform:general type:enhance Add new features urgency:3 Must be finished within a certain time frame.
Projects
None yet
Milestone
24.03
Development

Successfully merging a pull request may close this issue.

feat: add new resource policy page (keypair, user, project) lablup/backend.ai-webui
1 participant
@agatha197