Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: unquoted wildcard in mirror config #221

Merged
merged 1 commit into from
May 28, 2024
Merged

fix: unquoted wildcard in mirror config #221

merged 1 commit into from
May 28, 2024

Conversation

jgoelen
Copy link
Contributor

@jgoelen jgoelen commented May 24, 2024 •
edited
Loading

Description

Fix for issue #220

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update
  • Small minor change not affecting the Ansible Role code (GitHub Actions Workflow, Documentation etc.)

How Has This Been Tested?

Manual test on an on-prem RKE2 cluster.

@MonolithProjects MonolithProjects self-assigned this May 24, 2024
@MonolithProjects MonolithProjects added the bug Something isn't working label May 24, 2024
MonolithProjects
MonolithProjects approved these changes May 28, 2024
View reviewed changes
Copy link
Collaborator

@MonolithProjects MonolithProjects left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks

@MonolithProjects MonolithProjects merged commit 8ead9d0 into lablabs:main May 28, 2024
6 checks passed
@MonolithProjects MonolithProjects mentioned this pull request May 29, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MonolithProjects MonolithProjects MonolithProjects approved these changes

Assignees

@MonolithProjects MonolithProjects

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jgoelen @MonolithProjects