Fix removing old nodes after restore if rke2-server already started #219
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @glennpratt, thanks for this PR. Please resolve the conflict. |
…restore-remove-old-nodes
MonolithProjects
requested changes
May 28, 2024
There was a problem hiding this comment.
Hi @glennpratt, please fix the pipefail. Everything else looks fine. Thanks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
If rke2-server happened to start on the first node before the node removal section, nodes would not be removed.
This was because the removal was in
first_server.ymlwhich is gated byactive_server is not defined.https://github.com/lablabs/ansible-role-rke2/blob/main/tasks/main.yml#L46-L49
Type of change
How Has This Been Tested?
TBD