Persist client connection session #1552
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
defined with session after monitor that called with session was killed
'acquire', 'reserve' and 'monitor'.
When commands used without session argument, no changes should be seen.
But when those commands used with session argument, failed or killed
monitor command will start release procedure which will cancel all
reservations called with same session and release (but not delete) all places
acquired (locked) with the same session.
This should allow the coordinator to automatically reveal failed client and
clean the scene.
Actual intention is to use in cloud CI procedures to continue to work properly
in case of virtual environment containing client failure.
Signed-off-by: Greg Bronstain <[email protected]>
Signed-off-by: Greg Bronstain <[email protected]>
Signed-off-by: Greg Bronstain <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Added new feature - clean after failed session: to client added new string argument --session <SESSION_NAME> in commands
'acquire', 'reserve' and 'monitor'.
When those commands being used without session argument, no changes should be seen.
When those commands used with session argument, we keep the session name with place
and/or reservation and in case of failed or killed monitor, the coordinator will initiate clean procedure
which will cancel all reservations created with same session and release (but not delete!) all places
acquired (locked) with the same session.
This should allow the coordinator to automatically reveal event of failed client and clean the scene for next clients.
One of intentions here is to use in cloud CI procedures to continue to work properly in case of failure or disappearing of client in virtual environment.
Checklist