shelldriver: Fix xmodem

[JoshuaWatt]

xmodem was failing because it would consume the trailing newline character between the echo for the marker and the command output. Fix this by suppressing new line on the marker

Description

Checklist

• Documentation for the feature
• Tests for the feature

• The arguments and description in doc/configuration.rst have been updated

• Add a section on how to use the feature to doc/usage.rst

• Add a section on how to use the feature to doc/development.rst

• PR has been tested

• Man pages have been regenerated

[codecov]

Codecov Report

Patch coverage has no change and project coverage change: -0.1% ⚠️

Comparison is base (1052d34) 62.9% compared to head (2ddca3e) 62.9%.

❗ Current head 2ddca3e differs from pull request most recent head 5eff539. Consider uploading reports for the commit 5eff539 to get more accurate results

Additional details and impacted files

@@           Coverage Diff            @@
##           master   #1261     +/-   ##
========================================
- Coverage    62.9%   62.9%   -0.1%     
========================================
  Files         161     161             
  Lines       11861   11861             
========================================
- Hits         7470    7469      -1     
- Misses       4391    4392      +1     

Files Changed	Coverage Δ
labgrid/driver/shelldriver.py	27.1% <0.0%> (ø)

... and 1 file with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[Emantor]

Thanks for the fix!

[Bastian-Krause]

This should be back ported to stable.

[Bastian-Krause]

This should be back ported to stable.

Done.

[rohieb]

xmodem was failing because it would consume the trailing newline character between the echo for the marker and the command output. Fix this by suppressing new line on the marker

@JoshuaWatt do you still know what you were using on the target? Was it lrzsz or the busybox rx/sx tools, or something else? (I'm wondering because I didn't get it to work recently…)

[JoshuaWatt]

@rohieb I'm pretty sure it was lrzsz, but it was a while ago so I'm not positive