Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

First pass for the user documentation #91

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

First pass for the user documentation #91

wants to merge 3 commits into from

Conversation

Luthaf
Copy link
Contributor

@Luthaf Luthaf commented Jan 6, 2023

This is contains the same changes as #69, squashed into a single commit.


Here is a list of remaining things to do:

  • home page: explain what equistore is and why one would want to use it instead of the different doc sections (moved from get-started/equistore)
  • get-started/concepts: rewrite to not require previous knowledge of ACDC & friends, adding figures and other visual aids
  • get-started/installation: add some explanation and text around the commands

We also have to add how-to & friends, but It would be better of as separate PR to ensure we can merge this one quickly!

@github-actions
Copy link

github-actions bot commented Jan 6, 2023

Here is a pre-built version of the code in this pull request: wheels.zip, you can install it locally by unzipping wheels.zip and using pip to install the file matching your system

@github-actions
Copy link

github-actions bot commented Jan 6, 2023

The documentation for this pull request is (or will soon be) available on readthedocs: https://equistore--91.org.readthedocs.build/en/91/

Luthaf and others added 2 commits January 6, 2023 15:49
This adds a skeleton of the documentation, and uses sphinx-gallery
to render tutorials online.

Co-authored-by: Jigyasa Nigam <[email protected]>
Co-authored-by: HowWeiBin <[email protected]>
Co-authored-by: Philip Loche <[email protected]>
@Luthaf
Copy link
Contributor Author

Luthaf commented Jan 6, 2023

I removed the figures from the git history, to prevent polluting it too much until we converge to the final version. Here are the files for reference.

collection-blocks

single-block

Comment on lines +1 to +4
Equivariant Linear Model
------------------------

TBD
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since I am currently doing a Ridge implementation in equisolve, I am asking myself if an example really belongs here or do we just link to equisolve on this page?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My idea was more to provide a simple example using equistore.operations directly. Then the doc should 100% link to equisolve as a more complete implementation of this!

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Okay make sense.

@PicoCentauri
Copy link
Contributor

As agreed today with @curiosity54 and @HowWeiBin today we should try to keep this branch going. The user base is increasing and we need proper tutorials to clearly state what equistore can do and where to find things.

One example is that it may seems that equistore objects are immutable since python like operations (i.e. += etc) are not possible (yet). However, we already have a lot operations, buy we have to emphasize them. Maybe even with an example in the README.rst

from equistore import Tensormap
import equistore.operations as eqst

tensor = Tensormap(xxx)
tensor = eqst. add(tensor, 5)

Copy link
Contributor

@PicoCentauri PicoCentauri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I talked to @Luthaf yesterday about the the user documentation and we think it is already in a really good shape!

I like the tutorials. But, they require a bit more explanation of what is going on between the code cells. Also, please split the one big tutorial into a second at the point where you start training an actual model.

Comment on lines +325 to +329
# %%
#
# Training your first model using Equistore
# -----------------------------------------
#
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I suggest we split the Training your first model using Equistore into a second tutorial.

@Luthaf
Copy link
Contributor Author

Luthaf commented Feb 27, 2024

There have been a lot of improvement on the documentation, but this PR still contains some other tutorials that should be integrated. Keeping this open for now, until we have to time to finish the tutorial work.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants