Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Actually use MinGW on CI #643

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Actually use MinGW on CI #643

wants to merge 1 commit into from

Conversation

Luthaf
Copy link
Contributor

@Luthaf Luthaf commented May 31, 2024 •
edited by github-actions bot
Loading

The MinGW job was also using MSVC compiler by mistake

Contributor (creator of pull-request) checklist

  • Tests updated (for new features and bugfixes)?
  • Documentation updated (for new features)?
  • Issue referenced (for PRs that solve an issue)?

Reviewer checklist

  • CHANGELOG updated with public API or any other important changes?

馃摎 Download documentation preview for this pull-request

@Luthaf
Copy link
Contributor Author

Luthaf commented May 31, 2024

Not working yet, the output still contains

-- Building for: Visual Studio 16 2019
-- Running with CMake version 3.29.3
-- The C compiler identification is MSVC 19.29.30154.0
-- The CXX compiler identification is MSVC 19.29.30154.0

@Luthaf Luthaf force-pushed the actual-mingw-ci branch 3 times, most recently from 39a9ef4 to c42e72f Compare June 20, 2024 15:13
@Luthaf
Actually use MinGW on CI
10cc023 
The MinGW job was also using MSVC compiler by mistake
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@Luthaf