fix(yarn): improve Yarn version detection with better error handling #387
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Rui Chen <[email protected]>
Logging is not necessary at least now.
kyu08
approved these changes
Dec 12, 2024
There was a problem hiding this comment.
@chenrui333
Thank you for fixing this issue and taking your time!🙏
My Result handling was not appropriate.
Also, your comment is necessary and sufficient thanks!
I added minor changes deleting logging. 4479dfd
kyu08
changed the title
|
@chenrui333 |
|
@kyu08, happy to help, thanks for the merge! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #386
Homebrew/homebrew-core#200814