Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix echo queries result set #7

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Fix echo queries result set #7

wants to merge 3 commits into from

Conversation

sharedRoutine
Copy link

No description provided.

igalklebanov
igalklebanov requested changes Nov 24, 2023
View reviewed changes
Copy link
Member

@igalklebanov igalklebanov left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey 👋

Thank you! 💪

  • This is missing some tests.
  • Please add SINGLESTORE_LICENSE secret to your fork's settings to make GHA work. You can get a free license key in SingleStore's portal.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@igalklebanov igalklebanov igalklebanov requested changes

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@sharedRoutine @igalklebanov