feat: change logic of handling Gardener cluster #1341
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kyma-bot
added
kind/feature
Ressetkk
force-pushed
the
bug/gardener-dependency
branch
from
afe3c52
to
845d638
Compare
/kind feature /area api-gateway Remove hard dependency to Gardener resources and handle them on-demand if they are present. Introduce fallback mechaninsm if the resources expected on gardener cluster are not found. Still leave hard dependency to resources needed generally by the manager. Update tests to move the logic of dependency checking in reconcileKymaGateway (just adding required CRDs for fakes) Remove injecting Gardener CRDs where they aren't added into envtest runtime schema Create hack/crds directory containing all CRDs used in the tests
Ressetkk
force-pushed
the
bug/gardener-dependency
branch
from
845d638
to
fe3f04a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
/kind feature
/area api-gateway
Remove hard dependency to Gardener resources and handle them on-demand if they are present.
Introduce fallback mechaninsm if the resources expected on gardener cluster are not found.
Still leave hard dependency to resources needed generally by the manager.
Update tests to move the logic of dependency checking in reconcileKymaGateway (just adding required CRDs for fakes)
Remove injecting Gardener CRDs where they aren't added into envtest runtime schema
Create hack/crds directory containing all CRDs used in the tests
#1231