Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: modal:initialized callback + preload param + $.modal.get method. Fixes #279 #293

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

Zenoo
Copy link

@Zenoo Zenoo commented Jul 1, 2021

  • New event modal:initialized that runs once the modal content has been loaded.
  • New preload param, defaults to false. When set to true, the modal doesn't open on initialization, and stays preloaded until we .open() it ourselves.
  • New $.modal.get($elm) method that returns the modal instance of the linked element.

These changes should also fix #279.

@Zenoo
Copy link
Author

Zenoo commented Jul 1, 2021

As a side note, I couldn't get gulp to work with the version linked in package.json, so the minification comes from an automated VSCode tool.
Gulp 3 doesn't work with Node 11+, maybe upgrading it would be a good idea.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Embed code inside modal not loading on page load
1 participant