Fix bugs in GDS vertex property scanning #4417
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based on #4416
I fixed some edge cases in the NodeGroup::scan variant used by GDS vertex property scanning, and also fixed handling scans that run across node group boundaries.
I renamed
NodeGroupScanState::numScannedRows
tonextRowToScan
since they are functionally equivalent and nothing was ever usingnumScannedRows
as a size, just as an indication of the next row to scan. There was also a field callednextRowToScan
already inCSRNodeGroupScanState
, so that was just removed and the other field is now used in its place.