Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix bugs in GDS vertex property scanning #4417

Merged
merged 1 commit into from
Oct 24, 2024

Conversation

benjaminwinger
Copy link
Collaborator

Based on #4416

I fixed some edge cases in the NodeGroup::scan variant used by GDS vertex property scanning, and also fixed handling scans that run across node group boundaries.

I renamed NodeGroupScanState::numScannedRows to nextRowToScan since they are functionally equivalent and nothing was ever using numScannedRows as a size, just as an indication of the next row to scan. There was also a field called nextRowToScan already in CSRNodeGroupScanState, so that was just removed and the other field is now used in its place.

@benjaminwinger
Copy link
Collaborator Author

Do we not have CI for PRs which don't target the master branch? This was passing all tests locally (notably including the two tests which were failing for me initially on #4416).

@acquamarin acquamarin merged commit 3758003 into fts-gds-final Oct 24, 2024
@acquamarin acquamarin deleted the vertex-property-scan-fixes branch October 24, 2024 23:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants