Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement full text search #4416
base: master
Are you sure you want to change the base?
Implement full text search #4416
Changes from all commits
eb58dc1
b3d8c1b
6ac1bd2
f7a075d
5291903
8893911
3758003
65419a7
3a1d0cb
b281e02
2a15b82
34c3164
72c7a63
bba98f4
b5ae2a0
5228a31
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
Large diffs are not rendered by default.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Are you committing something on behalf of the user? You don't know if the user wants to do that. We should never do this. Instead, we need to error if the user has started a manual transaction. So we need a mechanism to tell whether the current function is being called inside a manual transaction or auto transaction. And if it is manual, we should error saying something like: "You cannot create an FTS index inside a manual transaction. CREATE_FTS_INDEX statements must be standalone queries."
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For transaction related issues, i think it is better to leave them after we support
copy
in manual transaction.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What is this alterTableEntry call doing? Why do you have to manually alter the catalog? Let's talk about this.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We have to create an index entry in nodetables, that's what the alterTableEntry is doing.