Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(e2e): rewrite e2e config init #13165

Merged
merged 3 commits into from
Mar 24, 2025
Merged

Conversation

slonka
Copy link
Contributor

@slonka slonka commented Mar 21, 2025

Motivation

That way in a parent project we can get the default and overwrite only the parts of the config that we care about. So if a change happens like in https://github.com/kumahq/kuma/pull/12982/files#diff-4097df65e73d6b3a2813df0ea3c87f15a6c43ba3aca9b73b3e60346758ef0344R65 we won't need to modify the parent project.

Instead of #13163 we can just manually init the e2e config and in parent project use init to change the Config.

First review parent project.

Implementation information

Manually init the e2e configuration by moving the init function to RunE2ESpecs.

Copy link
Contributor

Reviewer Checklist

🔍 Each of these sections need to be checked by the reviewer of the PR 🔍:
If something doesn't apply please check the box and add a justification if the reason is non obvious.

  • Is the PR title satisfactory? Is this part of a larger feature and should be grouped using > Changelog?
  • PR description is clear and complete. It Links to relevant issue as well as docs and UI issues
  • This will not break child repos: it doesn't hardcode values (.e.g "kumahq" as an image registry)
  • IPv6 is taken into account (.e.g: no string concatenation of host port)
  • Tests (Unit test, E2E tests, manual test on universal and k8s)
    • Don't forget ci/ labels to run additional/fewer tests
  • Does this contain a change that needs to be notified to users? In this case, UPGRADE.md should be updated.
  • Does it need to be backported according to the backporting policy? (this GH action will add "backport" label based on these file globs, if you want to prevent it from adding the "backport" label use no-backport-autolabel label)

@slonka slonka force-pushed the rewrite-config-init branch from fe1d861 to 462a4aa Compare March 24, 2025 12:32
@slonka slonka marked this pull request as ready for review March 24, 2025 14:09
@slonka slonka requested a review from a team as a code owner March 24, 2025 14:09
@slonka slonka requested review from jijiechen and lukidzi March 24, 2025 14:09
@slonka slonka merged commit 02ac3bb into kumahq:master Mar 24, 2025
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants