Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(policy): rename interpret_from_entries_as_rules market to is_from_as_rules #12979

Merged
merged 2 commits into from
Feb 28, 2025

Conversation

lobkovilya
Copy link
Contributor

@lobkovilya lobkovilya commented Feb 28, 2025

Motivation

Renamed the descriptor field in my previous PR but missed these policy markers.

Changelog: skip

@lobkovilya lobkovilya requested a review from a team as a code owner February 28, 2025 09:53
Copy link
Contributor

Reviewer Checklist

🔍 Each of these sections need to be checked by the reviewer of the PR 🔍:
If something doesn't apply please check the box and add a justification if the reason is non obvious.

  • Is the PR title satisfactory? Is this part of a larger feature and should be grouped using > Changelog?
  • PR description is clear and complete. It Links to relevant issue as well as docs and UI issues
  • This will not break child repos: it doesn't hardcode values (.e.g "kumahq" as an image registry)
  • IPv6 is taken into account (.e.g: no string concatenation of host port)
  • Tests (Unit test, E2E tests, manual test on universal and k8s)
    • Don't forget ci/ labels to run additional/fewer tests
  • Does this contain a change that needs to be notified to users? In this case, UPGRADE.md should be updated.
  • Does it need to be backported according to the backporting policy? (this GH action will add "backport" label based on these file globs, if you want to prevent it from adding the "backport" label use no-backport-autolabel label)

Signed-off-by: Ilya Lobkov <[email protected]>
@lobkovilya lobkovilya merged commit e775e18 into kumahq:master Feb 28, 2025
13 checks passed
@lobkovilya lobkovilya deleted the fix/rename-policy-marker branch February 28, 2025 13:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants