feat(inspect-api): return the list of outbounds #11556
Closed
+333
−25
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Ilya Lobkov <ilya.lobkov@konghq.com>
lahabana
reviewed
Sep 25, 2024
| @@ -2632,6 +2637,67 @@ components: | |||
| match: | |||
| type: object | |||
| x-go-type: interface{} | |||
| ResourceIdentifier: | |||
There was a problem hiding this comment.
It's technically a TypedResourceIdentifier no?
lahabana
reviewed
Sep 25, 2024
| @@ -981,13 +984,67 @@ func (r *resourceEndpoints) rulesForResource() restful.RouteFunction { | |||
| sort.Slice(httpMatches, func(i, j int) bool { | |||
| return httpMatches[i].Hash < httpMatches[j].Hash | |||
| }) | |||
| outbounds, err := r.outboundsForDPP(request.Request.Context(), dp, meshName) | |||
There was a problem hiding this comment.
For MeshGateways/_rules we create a fake dpp. Do you know how this works out?
lahabana
reviewed
Sep 25, 2024
| dpp *core_mesh.DataplaneResource, | ||
| meshName string, | ||
| ) ([]api_common.Outbound, error) { | ||
| meshContext, err := r.meshContextBuilder.BuildIfChanged(ctx, meshName, nil) |
There was a problem hiding this comment.
Do we get the full MeshContext again right? That's problematic then because the whole point of the _rules endpoint is that it didn't require getting all DPPs because this didn't scale at all in global as each of this calls would be in O(#Dpp).
If we need to break this then we'd need to rework the MeshContextBuillder to make this more workable, in which case we should punt this to 2.10.x
michaelbeaumont
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist prior to review
/_rulesto include the list of outbounds #11500syscall.Mkfifohave equivalent implementation on the other OS --ci/labels to run additional/fewer testsUPGRADE.md? --