Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(MeshRetry): allow setting numRetries to 0 to disable retries #10250

Merged
merged 3 commits into from
May 22, 2024

Conversation

lahabana
Copy link
Contributor

Currently if you have any retry policy inherited from anywhere you
wouldn't be able to remove the retries in a more specific policy.

This enables users to set {grpc,http}.numRetries = 0 in a more
specific policy and remove the retry filter completely.

It also disallows tcp.maxConnectAttempt = 0 which would create an
invalid envoy configuration.

fix #10248

Checklist prior to review

  • Link to relevant issue as well as docs and UI issues --
  • This will not break child repos: it doesn't hardcode values (.e.g "kumahq" as a image registry) and it will work on Windows, system specific functions like syscall.Mkfifo have equivalent implementation on the other OS --
  • Tests (Unit test, E2E tests, manual test on universal and k8s) --
    • Don't forget ci/ labels to run additional/fewer tests
  • Do you need to update UPGRADE.md? --
  • Does it need to be backported according to the backporting policy? (this GH action will add "backport" label based on these file globs, if you want to prevent it from adding the "backport" label use no-backport-autolabel label) --

Signed-off-by: Charly Molter <[email protected]>
Currently if you have any retry policy inherited from anywhere you
wouldn't be able to remove the retries in a more specific policy.

This enables users to set `{grpc,http}.numRetries = 0` in a more
specific policy and remove the retry filter completely.

It also disallows `tcp.maxConnectAttempt = 0` which would create an
invalid envoy configuration.

fix kumahq#10248

Signed-off-by: Charly Molter <[email protected]>
@lahabana lahabana requested a review from a team as a code owner May 16, 2024 12:10
@lahabana lahabana requested review from jijiechen, michaelbeaumont and bartsmykla and removed request for a team May 16, 2024 12:10
@lahabana lahabana added this to the 2.8.x milestone May 16, 2024
Signed-off-by: Charly Molter <[email protected]>
@lahabana lahabana merged commit e0221c6 into kumahq:master May 22, 2024
15 checks passed
@lahabana lahabana deleted the fix10248 branch May 22, 2024 14:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add ability to disable retries
2 participants