feat(MeshRetry): allow setting numRetries to 0 to disable retries #10250
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently if you have any retry policy inherited from anywhere you
wouldn't be able to remove the retries in a more specific policy.
This enables users to set
{grpc,http}.numRetries = 0
in a morespecific policy and remove the retry filter completely.
It also disallows
tcp.maxConnectAttempt = 0
which would create aninvalid envoy configuration.
fix #10248
Checklist prior to review
syscall.Mkfifo
have equivalent implementation on the other OS --ci/
labels to run additional/fewer testsUPGRADE.md
? --