Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(MeshExternalService): add bootstrapped files #10239

Merged
merged 5 commits into from
May 21, 2024

Conversation

slonka
Copy link
Contributor

@slonka slonka commented May 15, 2024

xrel #10238

just putting out the shell without schema to check if it works correctly (MeshExternalService is a bit like MeshService, not a plugin so things are a bit different and not automated like plugin policies)

Checklist prior to review

  • Link to relevant issue as well as docs and UI issues --
  • This will not break child repos: it doesn't hardcode values (.e.g "kumahq" as a image registry) and it will work on Windows, system specific functions like syscall.Mkfifo have equivalent implementation on the other OS --
  • Tests (Unit test, E2E tests, manual test on universal and k8s) --
    • Don't forget ci/ labels to run additional/fewer tests
  • Do you need to update UPGRADE.md? --
  • Does it need to be backported according to the backporting policy? (this GH action will add "backport" label based on these file globs, if you want to prevent it from adding the "backport" label use no-backport-autolabel label) --

@slonka slonka added the ci/skip-e2e-test PR: Don't run e2e tests label May 15, 2024
@slonka slonka marked this pull request as ready for review May 21, 2024 15:01
@slonka slonka requested a review from a team as a code owner May 21, 2024 15:01
@slonka slonka requested review from jijiechen, bartsmykla and lukidzi and removed request for a team May 21, 2024 15:01
@slonka slonka merged commit 5631efc into kumahq:master May 21, 2024
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci/skip-e2e-test PR: Don't run e2e tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants