chore: migrate from KTable to KTableView #3713
Merged
+57
−65
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for kuma-gui ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
johncowen
force-pushed
the
chore/k-table-data
branch
2 times, most recently
from
3c0cb35 to
3026838
Compare
johncowen
commented
Mar 31, 2025
packages/kuma-gui/src/app/application/components/app-collection/AppCollection.vue
Show resolved
Hide resolved
Signed-off-by: John Cowen <[email protected]>
johncowen
force-pushed
the
chore/k-table-data
branch
from
3026838 to
64ddf78
Compare
johncowen
commented
Mar 31, 2025
packages/kuma-gui/src/app/application/components/app-collection/AppCollection.vue
Show resolved
Hide resolved
johncowen
commented
Mar 31, 2025
packages/kuma-gui/src/app/application/components/app-collection/AppCollection.vue
Show resolved
Hide resolved
johncowen
commented
Mar 31, 2025
schogges
reviewed
Mar 31, 2025
packages/kuma-gui/src/app/policies/components/PolicyTypeEntryList.vue
Outdated
Show resolved
Hide resolved
Signed-off-by: John Cowen <[email protected]>
schogges
approved these changes
Apr 1, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Migrates our KTable usage to use KTableView, chosen because we don't want a Table to be concerned with data retrieval.
There are a few little weird things in this migration I'll note inline.
Closes #3655